Add WASI support for gloo-history.#405
Conversation
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Can you make it use cfg(target_os = "wasi") instead of a feature
That should make the wasi feature unnecessary and handle the compilation accordingly. Other than that, it looks good.
It would be great if you could also update CI to run tests on WASI target (using wasmtime) though
It's so new that when I looked through the documentation, it didn't even mention that the value of I tested it on the latest stable compiler and it works. I'll push the modified version later. |
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Thanks! Perhaps this is a good thing to update in the Rust documentation as well
2 participants
I've been trying to use
yewto render the page into the static HTML string on WASI. However,gloo-historycannot distinguish the browser WASM target (wasm32-unknown-unknownwithwasm-bindgen) and WASI target (wasm32-wasi), and it would choose wrong functions forwasm32-*.I have fixed it by using
target_os, and it would fix the problem.